Fix all 93 lint-go errors

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

pkg/runner/action_cache_test.go

@@ -53,20 +53,17 @@ func TestActionCache(t *testing.T) {
 		},
 	}
 	for _, c := range refs {
-		t.Run(c.Name, func(_ *testing.T) {
+		t.Run(c.Name, func(t *testing.T) {
 			sha, err := cache.Fetch(ctx, c.CacheDir, c.Repo, c.Ref, "")
-			if !a.NoError(err) || !a.NotEmpty(sha) {
-				return
-			}
+			require.NoError(t, err)
+			require.NotEmpty(t, sha)
 			atar, err := cache.GetTarArchive(ctx, c.CacheDir, sha, "js")
-			if !a.NoError(err) || !a.NotEmpty(atar) {
-				return
-			}
+			require.NoError(t, err)
+			require.NotEmpty(t, atar)
 			mytar := tar.NewReader(atar)
 			th, err := mytar.Next()
-			if !a.NoError(err) || !a.NotEqual(0, th.Size) {
-				return
-			}
+			require.NoError(t, err)
+			require.NotEqual(t, 0, th.Size)
 			buf := &bytes.Buffer{}
 			// G110: Potential DoS vulnerability via decompression bomb (gosec)
 			_, err = io.Copy(buf, mytar)

pkg/runner/expression.go

@@ -253,7 +253,7 @@ func (ee expressionEvaluator) evaluateScalarYamlNode(ctx context.Context, node *
 		return nil, err
 	}
 	if !strings.Contains(in, "${{") || !strings.Contains(in, "}}") {
-		return nil, nil
+		return nil, nil //nolint:nilnil
 	}
 	expr, _ := rewriteSubExpression(ctx, in, false)
 	res, err := ee.evaluate(ctx, expr, exprparser.DefaultStatusCheckNone)
@@ -366,7 +366,7 @@ func (ee expressionEvaluator) evaluateYamlNodeInternal(ctx context.Context, node
 	case yaml.SequenceNode:
 		return ee.evaluateSequenceYamlNode(ctx, node)
 	default:
-		return nil, nil
+		return nil, nil //nolint:nilnil
 	}
 }
 
@@ -432,7 +432,7 @@ func rewriteSubExpression(ctx context.Context, in string, forceFormat bool) (str
 		if strStart > -1 {
 			matches := strPattern.FindStringIndex(in[pos:])
 			if matches == nil {
-				return "", errors.New("unclosed string.")
+				return "", errors.New("unclosed string")
 			}
 
 			strStart = -1

pkg/runner/expression_test.go

@@ -150,7 +150,7 @@ func TestEvaluateRunContext(t *testing.T) {
 				}
 				assertObject.Equal(table.out, out, table.in)
 			} else {
-				assertObject.Error(err, table.in)
+				require.Error(t, err, table.in)
 				assertObject.Equal(table.errMesg, err.Error(), table.in)
 			}
 		})

pkg/runner/job_executor_test.go

@@ -239,7 +239,7 @@ func TestNewJobExecutor(t *testing.T) {
 
 	for _, tt := range table {
 		t.Run(tt.name, func(t *testing.T) {
-			t.Log("::group::%s\n", tt.name)
+			t.Logf("::group::%s\n", tt.name)
 
 			ctx := common.WithJobErrorContainer(context.Background())
 			jim := &jobInfoMock{}

pkg/runner/run_context.go

@@ -469,7 +469,7 @@ func (rc *RunContext) prepareServiceContainers(ctx context.Context, logger logru
 	return networkName, createAndDeleteNetwork, nil
 }
 
-func (rc *RunContext) execJobContainer(cmd []string, env map[string]string, user, workdir string) common.Executor {
+func (rc *RunContext) execJobContainer(cmd []string, env map[string]string, user, workdir string) common.Executor { //nolint:unparam
 	return func(ctx context.Context) error {
 		return rc.JobContainer.Exec(cmd, env, user, workdir)(ctx)
 	}

pkg/runner/runner_test.go

@@ -99,7 +99,7 @@ func TestGraphMissingFirst(t *testing.T) {
 	require.NoError(t, err)
 
 	plan, err := planner.PlanEvent("push")
-	assert.EqualError(t, err, "unable to build dependency graph for no first (no-first.yml)")
+	require.EqualError(t, err, "unable to build dependency graph for no first (no-first.yml)")
 	assert.NotNil(t, plan)
 	assert.Empty(t, plan.Stages)
 }
@@ -173,7 +173,7 @@ type TestJobFileInfo struct {
 }
 
 func (j *TestJobFileInfo) runTest(ctx context.Context, t *testing.T, cfg *Config) {
-	t.Log("::group::%s\n", j.workflowPath)
+	t.Logf("::group::%s\n", j.workflowPath)
 
 	log.SetLevel(logLevel)