Jason Song
a94a01bff2
Fix regression after merging upstream ( #54 )
...
Related to https://gitea.com/gitea/act/commit/229dbaf1532c7de89875153186e225b457307a03
Reviewed-on: https://gitea.com/gitea/act/pulls/54
2023-05-04 17:54:09 +08:00
Jason Song
229dbaf153
Merge tag 'nektos/v0.2.45'
2023-05-04 17:45:53 +08:00
f84a566ded
Replace backslash in GetActPath() for Windows ( #1777 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-03 19:12:36 +00:00
8913375af8
feat: implement steps.timeout-minutes ( #1776 )
...
* feat: implement steps.timeout-minutes
* Add imports
* refactor code
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-03 18:08:11 +00:00
ca9b783491
fix: don't allow -self-hosted mode as container image ( #1783 )
...
* fix: don't allow `-self-hosted` mode as container image
* fix: jobcontainer in hostmode platform
* Update run_context.go
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-03 17:49:17 +00:00
568124ca69
Refactor evaluate yaml node do not alter nested nodes ( #1761 )
...
* refactor: EvaluateYamlNode do not alter nested nodes
* fix build error
* fix op
* fix lint
* ...
* fixup
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-03 17:26:28 +00:00
aa21277380
fix: fallback to unauthenticated pull ( #1774 )
...
* fix: fallback to unauthenticated pull
* move logger def
* fixup
* add import
* .
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-03 16:44:26 +00:00
Shubh Bapna and GitHub
4721abfa6d
fix: remove hardcoded reference to github.com when using reusable remote workflows and remote actions ( #1784 )
...
* fix filename for remote reusable workflow and remove hardcoded reference to github.com
* remove hardcoded reference to github.com for remote action
2023-05-03 15:46:28 +00:00
Jason Song and GitHub
d77991c95a
Support cache ( #1770 )
...
* feat: port
* fix: use httprouter
* fix: WriteHeader
* fix: bolthold
* fix: bugs
* chore: one less file
* test: test handler
* fix: bug in id
* test: fix cases
* chore: tidy
* fix: use atomic.Int32
* fix: use atomic.Store
* feat: support close
* chore: lint
* fix: cache keys are case insensitive
* fix: options
* fix: use options
* fix: close
* fix: ignore close error
* Revert "fix: close"
This reverts commit d53ea7568ba03908eb153031c435008fd47e7ccb.
* fix: cacheUrlKey
* fix: nil close
* chore: lint code
* fix: test key
* test: case insensitive
* chore: lint
2023-04-28 15:57:40 +00:00
7cbb1a910e
Revert breaking docker socket changes ( #1763 )
...
* fix: rework docker socket changes
* fixup
* fixup
* fixes
* patch
* ...
* lint
* Fix docker outputs windows
* fix type
* Revert containerDaemonSocket breaking change
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-25 16:31:17 +00:00
a18648ee73
Support services credentials ( #51 )
...
If a service's image is from a container registry requires authentication, `act_runner` will need `credentials` to pull the image, see [documentation](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservicesservice_idcredentials ).
Currently, `act_runner` incorrectly uses the `credentials` of `containers` to pull services' images and the `credentials` of services won't be used, see the related code: https://gitea.com/gitea/act/src/commit/0c1f2edb996a87ee17dcf3cfa7259c04be02abd7/pkg/runner/run_context.go#L228-L269
Co-authored-by: Jason Song <[email protected] https://gitea.com/gitea/act/pulls/51
Reviewed-by: Jason Song <[email protected] [email protected] [email protected] [email protected]
2023-04-25 14:45:39 +08:00
Zettat123 and GitHub
baf3bcf48b
avoid using log.Fatal ( #1759 )
2023-04-25 02:09:54 +00:00
518d8c96f3
Keep the order of on when parsing workflow ( #46 )
...
Keep the order of `on` when parsing workflow, and fix the occasional unit test failure of `actions` like https://gitea.com/gitea/act/actions/runs/68
Co-authored-by: Jason Song <[email protected] https://gitea.com/gitea/act/pulls/46
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected] [email protected]
2023-04-24 23:16:41 +08:00
b6718fdf5d
fix: try finding a socket, otherwise fail, respect user choice ( #1745 )
...
* fix: try finding a socket, otherwise fail, respect user choice
* Update cmd/root.go
Co-authored-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-23 19:02:56 +00:00
Zettat123 and Jason Song
0c1f2edb99
Support specifying command for services ( #50 )
...
This PR is to support overwriting the default `CMD` command of `services` containers.
This is a Gitea specific feature and GitHub Actions doesn't support this syntax.
Reviewed-on: https://gitea.com/gitea/act/pulls/50
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-23 14:55:17 +08:00
Zettat123 and Jason Song
721857e4a0
Remove empty steps when decoding Job ( #49 )
...
Follow #48
Empty steps are invalid, so remove them when decoding `Job` from YAML.
Reviewed-on: https://gitea.com/gitea/act/pulls/49
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-21 20:21:15 +08:00
Zettat123 and Jason Song
6b1010ad07
Fix potential panic caused by nil Step ( #48 )
...
```yml
jobs:
job1:
steps:
- run: echo HelloWorld
- # empty step
```
If a job contains an empty step, `Job.Steps` will have a nil element and will cause panic when calling `Step.String()`.
See [the code of gitea](https://github.com/go-gitea/gitea/blob/948a9ee5e83586354461e2a0e5cdf00e0513e89d/models/actions/task.go#L300-L301 )
Reviewed-on: https://gitea.com/gitea/act/pulls/48
Co-authored-by: Zettat123 <[email protected] [email protected]
2023-04-21 14:45:38 +08:00
Zettat123 and Lunny Xiao
e12252a43a
Support intepolation for env of services ( #47 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/47
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected]
2023-04-20 16:24:31 +08:00
Zettat123 and Lunny Xiao
8609522aa4
Support services options ( #45 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/45
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected]
2023-04-19 21:53:57 +08:00
Zettat123 and Jason Song
6a876c4f99
Add go build tag to docker_network.go ( #44 )
...
Fix the build failure in https://gitea.com/gitea/act_runner/actions/runs/278/jobs/0
Reviewed-on: https://gitea.com/gitea/act/pulls/44
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-19 16:19:38 +08:00
sillyguodong and Jason Song
de529139af
Support configuration variables ( #43 )
...
related to: https://gitea.com/gitea/act_runner/issues/127
This PR make `act` support the expression like `${{ vars.YOUR_CUSTOM_VARIABLES }}`.
Reviewed-on: https://gitea.com/gitea/act/pulls/43
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-19 15:22:56 +08:00
35d6e9f71e
Remove the comment-out code. ( #1691 )
...
Co-authored-by: Jason Song <[email protected]
2023-04-19 03:46:00 +00:00
d3a56cdb69
Support services ( #42 )
...
Replace #5
Co-authored-by: Lunny Xiao <[email protected] [email protected] https://gitea.com/gitea/act/pulls/42
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-19 11:23:28 +08:00
9884da0122
fix: environment handling windows (host mode) ( #1732 )
...
* fix: environment handling windows (host mode)
* fixup
* fixup
* add more tests
* fixup
* fix setenv
* fixes
* [skip ci] Apply suggestions from code review
Co-authored-by: Jason Song <[email protected] [email protected]
2023-04-18 18:09:57 +00:00
de0644499a
fix: ensure networkmode "host" unless explicitly specified ( #1739 )
...
act defaults network mode to "host", but when `--container-options` are
passed on the CLI, it uses the docker CLI options parser, which fills
empty values with defaults, in which case network mode is set to
"default".
Unless the user explicitly sets `--container-options="--network=xxx"`,
we should always default to "host", to keep act's behaviour.
Co-authored-by: Markus Wolf <[email protected]
2023-04-18 14:37:59 +00:00
816a7d410a
Avoid using log.Fatal in pkg/* ( #1705 )
...
* fix: common
* fix: in runner
* fix: decodeNode
* fix: GetMatrixes
* Revert "fix: common"
This reverts commit 6599803b6ae3b7adc168ef41b4afd4d89fc22f34.
* fix: GetOutboundIP
* test: fix cases
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-18 14:17:36 +00:00
Galen Abell and Jason Song
9bdddf18e0
Parse secret inputs in reusable workflows ( #41 )
...
Secrets can be passed to reusable workflows, either explicitly by key or
implicitly by `inherit`:
https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
Reviewed-on: https://gitea.com/gitea/act/pulls/41
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-17 13:41:02 +08:00
Zettat123 and Jason Song
ac1ba34518
Fix incorrect job result status ( #40 )
...
Fix [#24039(GitHub)](https://github.com/go-gitea/gitea/issues/24039 )
At present, if a job fails in the `Set up job`, the result status of the job will still be `success`. The reason is that the `pre` steps don't call `SetJobError`, so the `jobError` will be nil when `post` steps setting the job result. See https://gitea.com/gitea/act/src/commit/5c4a96bcb797c7d013b878f1a3ceb74f9a834c64/pkg/runner/job_executor.go#L99
Reviewed-on: https://gitea.com/gitea/act/pulls/40
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-14 15:42:03 +08:00
ChristopherHX and GitHub
97749a27b9
fix: ghc assignment typo ( #1729 )
...
* fix: ghc assignment typo
* fixup server_url
2023-04-13 14:09:29 +00:00
d70b225e85
fix: reusable workflow panic ( #1728 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-13 13:47:59 +00:00
Markus Wolf and GitHub
c0130ed030
fix: add server_url attribute to github context ( #1727 )
...
* fix: add `server_url` attribute to github context
The `server_urL` attribute was missing in the `github` context.
Previously it was exposed as environment variable only.
Closes #1726
* fix: also set `api_url` and `graphql_url` attributes
2023-04-13 13:09:28 +00:00
Jason Song and Lunny Xiao
5c4a96bcb7
Avoid using log.Fatal in pkg/* ( #39 )
...
Follow https://github.com/nektos/act/pull/1705
Reviewed-on: https://gitea.com/gitea/act/pulls/39
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected]
2023-04-07 16:31:03 +08:00
Zettat123 and Jason Song
62abf4fe11
Add token for getting reusable workflows from local private repos ( #38 )
...
Partially fixes https://gitea.com/gitea/act_runner/issues/91
If the repository is private, we need to provide the token to the caller workflows to access the called reusable workflows from the same repository.
Reviewed-on: https://gitea.com/gitea/act/pulls/38
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-04-06 14:16:20 +08:00
Zettat123 and Lunny Xiao
cfedc518ca
Add With field to jobparser.Job ( #37 )
...
Partially Fixes [gitea/act_runner#91 comment](https://gitea.com/gitea/act_runner/issues/91#issuecomment-734544 )
nektos/act has added `With` to support reusable workflows (see [code](https://github.com/nektos/act/blob/68c72b9a51f4fa586af62619f9e6361e023a5d48/pkg/model/workflow.go#L160 ))
GitHub actions also support [`jobs.<job_id>.with`](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idwith )
Reviewed-on: https://gitea.com/gitea/act/pulls/37
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected]
2023-04-04 10:59:53 +08:00
8518d70bdf
feat: improve GetOutboundIP ( #1707 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-03-31 13:28:08 +00:00
d3dfde055a
fix: use os.UserHomeDir ( #1706 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-03-31 13:08:46 +00:00
Zettat123 and Jason Song
5e76853b55
Support reusable workflow ( #34 )
...
Fix https://gitea.com/gitea/act_runner/issues/80
Fix https://gitea.com/gitea/act_runner/issues/85
To support reusable workflows, I made some improvements:
- read `yml` files from both `.gitea/workflows` and `.github/workflows`
- clone repository for local reusable workflows because the runner doesn't have the code in its local directory
- fix the incorrect clone url like `https://https://gitea.com `
Co-authored-by: Jason Song <[email protected] https://gitea.com/gitea/act/pulls/34
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-03-29 13:59:22 +08:00
Jason Song
2eb4de02ee
Expose SetJob to make EraseNeeds work ( #35 )
...
Related to #33
Reviewed-on: https://gitea.com/gitea/act/pulls/35
Reviewed-by: Lunny Xiao <[email protected]
2023-03-29 13:57:29 +08:00
Kris and GitHub
75ffa205c4
Make sure working directory is respected when configured from matrix ( #1686 )
...
* Make sure working directory is respected when configured from matrix
* Fix regression by setting Workingdirectory on stepRun instead of step or too early
2023-03-28 12:24:03 +00:00
Jason Song
342ad6a51a
Keep the order of jobs in the workflow file when parsing ( #33 )
...
Keep the order of jobs in the workflow file when parsing, and it will make it possible for Gitea to show jobs in the original order on UI.
Reviewed-on: https://gitea.com/gitea/act/pulls/33
Reviewed-by: Lunny Xiao <[email protected]
2023-03-28 11:38:40 +08:00
Jason Song
568f053723
Revert "Erase needs of job in SingleWorkflow ( #9 )" ( #32 )
...
This reverts commit 1ba076d321https://github.com/go-gitea/gitea/blob/023e61e678dc353fa6c9b0299c37f48e98a3c7af/models/actions/run.go#L200
Or Gitea won't be able to get `Needs` of jobs.
Reviewed-on: https://gitea.com/gitea/act/pulls/32
Reviewed-by: Zettat123 <[email protected]
2023-03-27 17:46:50 +08:00
Lunny Xiao and Jason Song
83fb85f702
Fix bug ( #31 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/31
Reviewed-by: Jason Song <[email protected] [email protected] [email protected]
2023-03-26 21:01:46 +08:00
3daf313205
chore(yaml): Improve ParseRawOn ( #28 )
...
See [act_runner #71 comment](https://gitea.com/gitea/act_runner/issues/71#issuecomment-733806 ), we need to handle `nil interface{}` in `ParseRawOn` function
Co-authored-by: Lunny Xiao <[email protected] https://gitea.com/gitea/act/pulls/28
Reviewed-by: Lunny Xiao <[email protected] [email protected] [email protected] [email protected]
2023-03-25 12:13:50 +08:00
Lunny Xiao and appleboy
7c5400d75b
ParseRawOn support schedules ( #29 )
...
Fix gitea/act_runner#71
Reviewed-on: https://gitea.com/gitea/act/pulls/29
Reviewed-by: Jason Song <[email protected] [email protected] [email protected] [email protected]
2023-03-24 20:15:46 +08:00
Jason Song
929ea6df75
Support gitea context ( #27 )
...
And we will be able to use context like `${{ gitea.repository }}` in workflows yaml files, it's same as `${{ github.repository }}`
Reviewed-on: https://gitea.com/gitea/act/pulls/27
Reviewed-by: Zettat123 <[email protected]
2023-03-23 12:14:28 +08:00
Zettat123 and Lunny Xiao
f6a8a0e643
Add extra path env for running go actions ( #26 )
...
At present, the runner can't run go actions even if the go environment has been set by the `setup-go` action. The reason is that `setup-go` will add the go related paths to [`GITHUB_PATH`](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path ) but in #22 I forgot to apply them before running go actions. After adding the `ApplyExtraPath` function, the `setup-go` action runs properly.
Reviewed-on: https://gitea.com/gitea/act/pulls/26
Reviewed-by: Jason Song <[email protected] [email protected] [email protected] [email protected]
2023-03-21 15:31:30 +08:00
636c8a34ae
feat: specify matrix on command line ( #1675 )
...
* added matrix option
* select the correct subset of matrix configuration after producing all the matrix configuration
* add tests
* update readme
* lint fix
* remove matrix from readme
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-03-19 17:25:55 +00:00
a1012112796 and Lunny Xiao
556fd20aed
make sure special logs be sent to gitea's server ( #25 )
...
example:
https://gitea.com/a1012112796/test_action/actions/runs/7
TODO: special handle them on ui
Signed-off-by: a1012112796 <[email protected] https://gitea.com/gitea/act/pulls/25
Reviewed-by: Jason Song <[email protected] [email protected] [email protected] [email protected]
2023-03-17 23:01:31 +08:00
Jason Song
a8298365fe
Fix incompatibility caused by tracking upstream add actions to test it ( #24 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/24
2023-03-16 15:00:11 +08:00
Jason Song
1dda0aec69
Merge tag 'nektos/v0.2.43'
...
Conflicts:
pkg/container/docker_run.go
pkg/runner/action.go
pkg/runner/logger.go
pkg/runner/run_context.go
pkg/runner/runner.go
pkg/runner/step_action_remote_test.go
2023-03-16 11:45:29 +08:00
Jason Song
Shubh BapnaandGitHub
Galen AbellandJason Song
Markus WolfandGitHub
KrisandGitHub
a1012112796andLunny Xiao