Shubh Bapna and GitHub
4721abfa6d
fix: remove hardcoded reference to github.com when using reusable remote workflows and remote actions ( #1784 )
...
* fix filename for remote reusable workflow and remove hardcoded reference to github.com
* remove hardcoded reference to github.com for remote action
2023-05-03 15:46:28 +00:00
appleboy and techknowlogick
b498341857
build: improve compression and update GitHub actions ( #168 )
...
- Add `dist` to .gitignore for gorelease binary folder
- Replace tar command with xz command in .goreleaser.yaml for better compression
ref: https://gitea.com/gitea/homebrew-gitea/pulls/164
Signed-off-by: appleboy <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/168
Reviewed-by: techknowlogick <[email protected] >
Co-authored-by: appleboy <[email protected] >
Co-committed-by: appleboy <[email protected] >
v0.1.6
2023-05-01 21:59:43 +08:00
3eb6e83ea4
build(deps): bump github.com/docker/cli ( #1780 )
...
Bumps [github.com/docker/cli](https://github.com/docker/cli ) from 23.0.4+incompatible to 23.0.5+incompatible.
- [Release notes](https://github.com/docker/cli/releases )
- [Commits](https://github.com/docker/cli/compare/v23.0.4...v23.0.5 )
---
updated-dependencies:
- dependency-name: github.com/docker/cli
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-01 03:49:17 +00:00
15eb1fa92a
build(deps): bump github.com/opencontainers/image-spec ( #1781 )
...
Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec ) from 1.1.0-rc2.0.20221005185240-3a7f492d3f1b to 1.1.0-rc.3.
- [Release notes](https://github.com/opencontainers/image-spec/releases )
- [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md )
- [Commits](https://github.com/opencontainers/image-spec/commits/v1.1.0-rc3 )
---
updated-dependencies:
- dependency-name: github.com/opencontainers/image-spec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-05-01 03:30:50 +00:00
1f9bbe12dd
build(deps): bump github.com/docker/docker ( #1779 )
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 23.0.4+incompatible to 23.0.5+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v23.0.4...v23.0.5 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-01 03:14:03 +00:00
GitHub Actions
f1df2ca5d6
chore: bump VERSION to 0.2.45
2023-05-01 02:18:34 +00:00
appleboy and Jason Song
0d727eb262
build: optimize Dockerfile and update dependencies ( #162 )
...
- Update base images to golang:1.20-alpine3.17 and alpine:3.17
- Replace `--update-cache` with `--no-cache` in apk add command
- Specify exact versions for make, git, and bash packages
Signed-off-by: appleboy <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/162
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: appleboy <[email protected] >
Co-committed-by: appleboy <[email protected] >
2023-04-29 12:07:15 +08:00
7c71c94366
Document persisting /data for docker container ( #160 )
...
`/data` must be kept between container restarts.
Co-authored-by: Valentin Brandl <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/160
Reviewed-by: Lunny Xiao <[email protected] >
Reviewed-by: techknowlogick <[email protected] >
Co-authored-by: vbrandl <[email protected] >
Co-committed-by: vbrandl <[email protected] >
v0.1.5
2023-04-29 03:05:00 +08:00
Jason Song and GitHub
d77991c95a
Support cache ( #1770 )
...
* feat: port
* fix: use httprouter
* fix: WriteHeader
* fix: bolthold
* fix: bugs
* chore: one less file
* test: test handler
* fix: bug in id
* test: fix cases
* chore: tidy
* fix: use atomic.Int32
* fix: use atomic.Store
* feat: support close
* chore: lint
* fix: cache keys are case insensitive
* fix: options
* fix: use options
* fix: close
* fix: ignore close error
* Revert "fix: close"
This reverts commit d53ea7568ba03908eb153031c435008fd47e7ccb.
* fix: cacheUrlKey
* fix: nil close
* chore: lint code
* fix: test key
* test: case insensitive
* chore: lint
2023-04-28 15:57:40 +00:00
appleboy and Jason Song
49d2cb0cb5
ci: improve API usage and test robustness across platforms ( #159 )
...
- Add `dir: ./dist/` to `.goreleaser.yaml` builds configuration
fix https://gitea.com/gitea/act_runner/issues/158
Signed-off-by: appleboy <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/159
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: appleboy <[email protected] >
Co-committed-by: appleboy <[email protected] >
2023-04-28 23:46:46 +08:00
sillyguodong and Jason Song
85626b6bbd
Support configuration variables ( #157 )
...
related to: https://gitea.com/gitea/act_runner/issues/127
`act_runner` only needs to pass `vars` from `Gitea` to `act`.
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/157
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: sillyguodong <[email protected] >
Co-committed-by: sillyguodong <[email protected] >
2023-04-28 22:06:08 +08:00
Zettat123 and Jason Song
35400f76fa
Add parent directory for working directory ( #154 )
...
Fixes #145
At present, the working directory of a work flow is a path like `/<owner>/<repo>`, so the directory may conflict with system directory like `/usr/bin`. We need to add a parent directory for the working directory.
In this PR, the parent directory is `/workspace` by default and users could configure it by the `workdir_parent` option.
This change doesn't affect the host mode because in host mode the working directory will always be in `$HOME/.cache/act/` directory.
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/154
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-28 22:03:52 +08:00
Jason Song
0cf31b2d22
Update docker image tag ( #153 )
...
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/153
v0.1.4
2023-04-27 15:02:39 +08:00
Søren L. Hansen and Jason Song
c8cc7b2448
Workflow commands ( #149 )
...
Establishes a simple framework for supporting workflow commands.
Fully implements `::add-mask::`, `::debug::`, and `::stop-commands::`.
Addresses #148
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/149
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Søren L. Hansen <[email protected] >
Co-committed-by: Søren L. Hansen <[email protected] >
v0.1.3
2023-04-27 12:32:48 +08:00
Jason Song
3be962cdb3
Rename the download folder from main -> nightly ( #152 )
...
Close https://gitea.com/gitea/act_runner/issues/117
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/152
2023-04-27 12:23:15 +08:00
Jason Song
a5edbc9ac4
Release docker images ( #151 )
...
Did some tests to make sure it worked.
See https://hub.docker.com/r/gitea/act_runner/tags
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/151
2023-04-27 12:08:41 +08:00
seepine and Jason Song
66bab3d805
ci(actions): add build docker image workflow ( #118 )
...
### Add secret
```
DOCKERHUB_TOKEN=xxx
```
### Tag
when tag like `v1.0.0`, it will build multi platform docker image `gitea/act_runner:1.0.0` and `gitea/act_runner:latest`, then push to docker hub
### Use
> volume `/data` save `.runner` config file
> volume `/root/.cache` save actcache and actions cache
```sh
docker run -e GITEA_INSTANCE_URL=*** \
-e GITEA_RUNNER_REGISTRATION_TOKEN=*** \
-e GITEA_RUNNER_NAME=*** \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /root/act_runner/data:/data \
-v /root/act_runner/cache:/root/.cache \
gitea/act_runner
```
Test join runners success

Test run action success

Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/118
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: seepine <[email protected] >
Co-committed-by: seepine <[email protected] >
2023-04-27 11:32:28 +08:00
c81a770bc5
chore: run act from cli on linux ( #1758 )
...
* chore: run act from cli on linux
To prevent issues like #1756 in the future, we need to
run act from the cli through all the root setup code.
This ensures that the basic CLI setup can succeed.
Co-authored-by: Björn Brauer <[email protected] >
* chore: set platform spec to use
---------
Co-authored-by: Björn Brauer <[email protected] >
Co-authored-by: ChristopherHX <[email protected] >
2023-04-25 17:32:34 +00:00
7cbb1a910e
Revert breaking docker socket changes ( #1763 )
...
* fix: rework docker socket changes
* fixup
* fixup
* fixes
* patch
* ...
* lint
* Fix docker outputs windows
* fix type
* Revert containerDaemonSocket breaking change
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-25 16:31:17 +00:00
a18648ee73
Support services credentials ( #51 )
...
If a service's image is from a container registry requires authentication, `act_runner` will need `credentials` to pull the image, see [documentation](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservicesservice_idcredentials ).
Currently, `act_runner` incorrectly uses the `credentials` of `containers` to pull services' images and the `credentials` of services won't be used, see the related code: https://gitea.com/gitea/act/src/commit/0c1f2edb996a87ee17dcf3cfa7259c04be02abd7/pkg/runner/run_context.go#L228-L269
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act/pulls/51
Reviewed-by: Jason Song <[email protected] >
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-25 14:45:39 +08:00
Zettat123 and GitHub
baf3bcf48b
avoid using log.Fatal ( #1759 )
2023-04-25 02:09:54 +00:00
techknowlogick and techknowlogick
293926f5d5
bump modernc.org/sqlite ( #141 )
...
fix #140
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/141
Co-authored-by: techknowlogick <[email protected] >
Co-committed-by: techknowlogick <[email protected] >
2023-04-25 03:16:01 +08:00
You-Sheng Yang and techknowlogick
43c5ba923f
make: skip --disable-content-trust at docker buildx ( #139 )
...
`docker build` may be aliased as `docker buildx build`, which doesn't support --disable-content-trust switch.
Signed-off-by: You-Sheng Yang <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/139
Reviewed-by: techknowlogick <[email protected] >
Co-authored-by: You-Sheng Yang <[email protected] >
Co-committed-by: You-Sheng Yang <[email protected] >
2023-04-25 03:15:48 +08:00
518d8c96f3
Keep the order of on when parsing workflow ( #46 )
...
Keep the order of `on` when parsing workflow, and fix the occasional unit test failure of `actions` like https://gitea.com/gitea/act/actions/runs/68
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act/pulls/46
Reviewed-by: Lunny Xiao <[email protected] >
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: sillyguodong <[email protected] >
Co-committed-by: sillyguodong <[email protected] >
2023-04-24 23:16:41 +08:00
2ea7891787
build(deps): bump github.com/moby/buildkit from 0.11.5 to 0.11.6 ( #1755 )
...
Bumps [github.com/moby/buildkit](https://github.com/moby/buildkit ) from 0.11.5 to 0.11.6.
- [Release notes](https://github.com/moby/buildkit/releases )
- [Commits](https://github.com/moby/buildkit/compare/v0.11.5...v0.11.6 )
---
updated-dependencies:
- dependency-name: github.com/moby/buildkit
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-24 04:02:30 +00:00
16f35f64eb
build(deps): bump github.com/docker/docker ( #1754 )
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 23.0.3+incompatible to 23.0.4+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v23.0.3...v23.0.4 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-24 03:46:51 +00:00
ded31bdbc0
build(deps): bump github.com/docker/cli ( #1753 )
...
Bumps [github.com/docker/cli](https://github.com/docker/cli ) from 23.0.3+incompatible to 23.0.4+incompatible.
- [Release notes](https://github.com/docker/cli/releases )
- [Commits](https://github.com/docker/cli/compare/v23.0.3...v23.0.4 )
---
updated-dependencies:
- dependency-name: github.com/docker/cli
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-24 03:28:43 +00:00
60bcfb5d4f
build(deps): bump codecov/codecov-action from 3.1.2 to 3.1.3 ( #1752 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <[email protected] >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-24 03:13:14 +00:00
techknowlogick and Jason Song
acc5afc428
allow building act_runner with cgo ( #137 )
...
for platforms not supported by moderc.org/sqlite
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/137
Reviewed-by: Lunny Xiao <[email protected] >
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: techknowlogick <[email protected] >
Co-committed-by: techknowlogick <[email protected] >
2023-04-24 10:45:51 +08:00
7c6237d93f
ci: deduplicate running workflows ( #1751 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-23 19:18:38 +00:00
b6718fdf5d
fix: try finding a socket, otherwise fail, respect user choice ( #1745 )
...
* fix: try finding a socket, otherwise fail, respect user choice
* Update cmd/root.go
Co-authored-by: Jason Song <[email protected] >
* Update cmd/root.go
Co-authored-by: Jason Song <[email protected] >
---------
Co-authored-by: Jason Song <[email protected] >
2023-04-23 19:02:56 +00:00
Zettat123 and Jason Song
0c1f2edb99
Support specifying command for services ( #50 )
...
This PR is to support overwriting the default `CMD` command of `services` containers.
This is a Gitea specific feature and GitHub Actions doesn't support this syntax.
Reviewed-on: https://gitea.com/gitea/act/pulls/50
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-23 14:55:17 +08:00
Zettat123 and Jason Song
721857e4a0
Remove empty steps when decoding Job ( #49 )
...
Follow #48
Empty steps are invalid, so remove them when decoding `Job` from YAML.
Reviewed-on: https://gitea.com/gitea/act/pulls/49
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-21 20:21:15 +08:00
Zettat123 and Jason Song
6b1010ad07
Fix potential panic caused by nil Step ( #48 )
...
```yml
jobs:
job1:
steps:
- run: echo HelloWorld
- # empty step
```
If a job contains an empty step, `Job.Steps` will have a nil element and will cause panic when calling `Step.String()`.
See [the code of gitea](https://github.com/go-gitea/gitea/blob/948a9ee5e83586354461e2a0e5cdf00e0513e89d/models/actions/task.go#L300-L301 )
Reviewed-on: https://gitea.com/gitea/act/pulls/48
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-21 14:45:38 +08:00
Zettat123 and Lunny Xiao
27a1a90d25
Upgrade act ( #135 )
...
Related to:
- https://gitea.com/gitea/act/pulls/45
- https://gitea.com/gitea/act/pulls/47
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/135
Reviewed-by: techknowlogick <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-21 10:48:26 +08:00
Jason Song and Lunny Xiao
83ec0ba909
Support upload outputs and use needs context ( #133 )
...
See [Example usage of the needs context](https://docs.github.com/en/actions/learn-github-actions/contexts#example-usage-of-the-needs-context ).
Related to:
- [actions-proto-def #5 ](https://gitea.com/gitea/actions-proto-def/pulls/5 )
- [gitea #24230 ](https://github.com/go-gitea/gitea/pull/24230 )
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/133
Reviewed-by: Lunny Xiao <[email protected] >
Reviewed-by: Zettat123 <[email protected] >
Co-authored-by: Jason Song <[email protected] >
Co-committed-by: Jason Song <[email protected] >
2023-04-20 23:27:46 +08:00
Zettat123 and Lunny Xiao
e12252a43a
Support intepolation for env of services ( #47 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/47
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-20 16:24:31 +08:00
Zettat123 and Lunny Xiao
8609522aa4
Support services options ( #45 )
...
Reviewed-on: https://gitea.com/gitea/act/pulls/45
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-19 21:53:57 +08:00
Jason Song
ed86e2f15a
Update workflow files ( #131 )
...
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/131
2023-04-19 17:46:52 +08:00
Jason Song
d4bebccc12
Update dependencies ( #130 )
...
Related to:
- https://gitea.com/gitea/act/pulls/44
- https://gitea.com/gitea/actions-proto-def/pulls/5
- https://gitea.com/gitea/actions-proto-def/pulls/7
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/130
2023-04-19 16:50:07 +08:00
Zettat123 and Jason Song
6a876c4f99
Add go build tag to docker_network.go ( #44 )
...
Fix the build failure in https://gitea.com/gitea/act_runner/actions/runs/278/jobs/0
Reviewed-on: https://gitea.com/gitea/act/pulls/44
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-19 16:19:38 +08:00
sillyguodong and Jason Song
de529139af
Support configuration variables ( #43 )
...
related to: https://gitea.com/gitea/act_runner/issues/127
This PR make `act` support the expression like `${{ vars.YOUR_CUSTOM_VARIABLES }}`.
Reviewed-on: https://gitea.com/gitea/act/pulls/43
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: sillyguodong <[email protected] >
Co-committed-by: sillyguodong <[email protected] >
2023-04-19 15:22:56 +08:00
Zettat123 and Jason Song
c75b67e892
Upgrade act ( #128 )
...
Follow https://gitea.com/gitea/act/pulls/42
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/128
Reviewed-by: Lunny Xiao <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-19 14:53:23 +08:00
3715266494
Improve watchAndRun ( #1743 )
...
* fix: improve watchAndRun
* fix: lint
* fix: lint
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-19 04:19:40 +00:00
35d6e9f71e
Remove the comment-out code. ( #1691 )
...
Co-authored-by: Jason Song <[email protected] >
2023-04-19 03:46:00 +00:00
d3a56cdb69
Support services ( #42 )
...
Replace #5
Co-authored-by: Lunny Xiao <[email protected] >
Co-authored-by: Jason Song <[email protected] >
Reviewed-on: https://gitea.com/gitea/act/pulls/42
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-19 11:23:28 +08:00
Zettat123 and Jason Song
bc6031eff7
Fix reporting log in Reporter.Close ( #126 )
...
Previously, the `Close` func returns incorrectly so that the logs may not be reported.
This PR fixes the incorrect return and sets the `StoppedAt` to get the correct task duration.
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/126
Reviewed-by: Jason Song <[email protected] >
Co-authored-by: Zettat123 <[email protected] >
Co-committed-by: Zettat123 <[email protected] >
2023-04-19 11:17:49 +08:00
d970056601
typo: fix expression of warning message on macOS ( #1693 )
...
Co-authored-by: Jason Song <[email protected] >
2023-04-19 03:00:33 +00:00
9884da0122
fix: environment handling windows (host mode) ( #1732 )
...
* fix: environment handling windows (host mode)
* fixup
* fixup
* add more tests
* fixup
* fix setenv
* fixes
* [skip ci] Apply suggestions from code review
Co-authored-by: Jason Song <[email protected] >
* Update side effects
---------
Co-authored-by: Jason Song <[email protected] >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-18 18:09:57 +00:00
de0644499a
fix: ensure networkmode "host" unless explicitly specified ( #1739 )
...
act defaults network mode to "host", but when `--container-options` are
passed on the CLI, it uses the docker CLI options parser, which fills
empty values with defaults, in which case network mode is set to
"default".
Unless the user explicitly sets `--container-options="--network=xxx"`,
we should always default to "host", to keep act's behaviour.
Co-authored-by: Markus Wolf <[email protected] >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-04-18 14:37:59 +00:00