mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-08-07 09:24:22 +02:00
4c2ab943a8
gitea can not consume the runner's api by version while it's version mismatches the module version:
```
go: gitea.com/gitea/runner@v3.0.1: invalid version: module contains a go.mod file,
so module path must match major version ("gitea.com/gitea/runner/v3")
```
Fix that by bumping the module version now. The existing `v3.0.0` and `v3.0.1` tags stay unusable, so a new tag is needed after this lands.
Also drop the version `-X` linker flags, which would otherwise have to repeat the new path in both `Makefile` and `.goreleaser.yaml`, where a stale path makes injection silently no-op. Go has recorded the module version in the build info since 1.24, so `Version()` reads it from there, keeping the variable as an override for builds without a VCS stamp.
That part started as https://gitea.com/gitea/runner/pulls/1137 but belongs here: the stamp resolves against the tags that are legal for the module path, so without the `/v3` bump it would report `v1.0.9-0.<ts>-<sha>`. Since `release-nightly.yml` triggers on every push to `main`, splitting them would publish a nightly with a `v1` version.
---------
Co-authored-by: bircni <bircni@icloud.com>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1136
Reviewed-by: techknowlogick <9+techknowlogick@noreply.gitea.com>
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
68 lines
1.5 KiB
Go
68 lines
1.5 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.com/gitea/runner/v3/act/model"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.yaml.in/yaml/v4"
|
|
)
|
|
|
|
func TestMaxParallelStrategy(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
maxParallelString string
|
|
expectedMaxParallel int
|
|
}{
|
|
{
|
|
name: "max-parallel-1",
|
|
maxParallelString: "1",
|
|
expectedMaxParallel: 1,
|
|
},
|
|
{
|
|
name: "max-parallel-2",
|
|
maxParallelString: "2",
|
|
expectedMaxParallel: 2,
|
|
},
|
|
{
|
|
name: "max-parallel-default",
|
|
maxParallelString: "",
|
|
expectedMaxParallel: 4,
|
|
},
|
|
{
|
|
name: "max-parallel-10",
|
|
maxParallelString: "10",
|
|
expectedMaxParallel: 10,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
matrix := map[string][]any{
|
|
"version": {1, 2, 3, 4, 5},
|
|
}
|
|
|
|
var rawMatrix yaml.Node
|
|
err := rawMatrix.Encode(matrix)
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
|
|
job := &model.Job{
|
|
Strategy: &model.Strategy{
|
|
MaxParallelString: tt.maxParallelString,
|
|
RawMatrix: rawMatrix,
|
|
},
|
|
}
|
|
|
|
matrixes, err := job.GetMatrixes()
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.NotNil(t, matrixes)
|
|
assert.Len(t, matrixes, 5)
|
|
assert.Equal(t, tt.expectedMaxParallel, job.Strategy.MaxParallel)
|
|
})
|
|
}
|
|
}
|