mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-06-09 18:44:23 +02:00
270ea41232
Running the full suite under `-race` (dropping `-short`) exposed pre-existing data races in parallel matrix-job execution, fixed by not sharing mutable state across combinations: - `containerDaemonSocket()`/`validVolumes()` derive per-job values instead of mutating shared `Config` - `getWorkflowSecrets` builds a fresh map, `rc.steps()` clones each step, and go-git workdir access is serialized - every write to a shared `Job`'s result/outputs runs under a per-`Job` lock, each combo interpolating outputs from a pristine snapshot (last wins, as on GitHub) ### Test suite - capability gates (docker / network / host-tools / Linux) replace the `-short` skips, and the suite runs offline via local fixtures (the artifact flow uses an in-process loopback server, only the docker-action force-pull needs the network) - drops redundant tests, adds a regression test for https://gitea.com/gitea/runner/issues/981 and a docker-in-docker harness (`make test-dind`) --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/runner/pulls/994 Reviewed-by: Nicolas <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
28 lines
766 B
Go
28 lines
766 B
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package container
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
mobyclient "github.com/moby/moby/client"
|
|
)
|
|
|
|
// requireDocker skips the test unless a reachable docker daemon is available.
|
|
// GetDockerClient succeeds even without a running daemon (its ping is best-effort),
|
|
// so the daemon has to be pinged explicitly here to decide whether to skip.
|
|
func requireDocker(t *testing.T) {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
cli, err := GetDockerClient(ctx)
|
|
if err != nil {
|
|
t.Skipf("skipping: docker client unavailable: %v", err)
|
|
}
|
|
defer cli.Close()
|
|
if _, err := cli.Ping(ctx, mobyclient.PingOptions{}); err != nil {
|
|
t.Skipf("skipping: docker daemon unreachable: %v", err)
|
|
}
|
|
}
|