mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-08-07 17:34:22 +02:00
4c2ab943a8
gitea can not consume the runner's api by version while it's version mismatches the module version:
```
go: gitea.com/gitea/runner@v3.0.1: invalid version: module contains a go.mod file,
so module path must match major version ("gitea.com/gitea/runner/v3")
```
Fix that by bumping the module version now. The existing `v3.0.0` and `v3.0.1` tags stay unusable, so a new tag is needed after this lands.
Also drop the version `-X` linker flags, which would otherwise have to repeat the new path in both `Makefile` and `.goreleaser.yaml`, where a stale path makes injection silently no-op. Go has recorded the module version in the build info since 1.24, so `Version()` reads it from there, keeping the variable as an override for builds without a VCS stamp.
That part started as https://gitea.com/gitea/runner/pulls/1137 but belongs here: the stamp resolves against the tags that are legal for the module path, so without the `/v3` bump it would report `v1.0.9-0.<ts>-<sha>`. Since `release-nightly.yml` triggers on every push to `main`, splitting them would publish a nightly with a `v1` version.
---------
Co-authored-by: bircni <bircni@icloud.com>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1136
Reviewed-by: techknowlogick <9+techknowlogick@noreply.gitea.com>
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
87 lines
1.5 KiB
Go
87 lines
1.5 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// Copyright 2022 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.com/gitea/runner/v3/act/model"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestStepFactoryNewStep(t *testing.T) {
|
|
table := []struct {
|
|
name string
|
|
model *model.Step
|
|
check func(s step) bool
|
|
}{
|
|
{
|
|
name: "StepRemoteAction",
|
|
model: &model.Step{
|
|
Uses: "remote/action@v1",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepActionRemote)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepLocalAction",
|
|
model: &model.Step{
|
|
Uses: "./action@v1",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepActionLocal)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepDocker",
|
|
model: &model.Step{
|
|
Uses: "docker://image:tag",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepDocker)
|
|
return ok
|
|
},
|
|
},
|
|
{
|
|
name: "StepRun",
|
|
model: &model.Step{
|
|
Run: "cmd",
|
|
},
|
|
check: func(s step) bool {
|
|
_, ok := s.(*stepRun)
|
|
return ok
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range table {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
sf := &stepFactoryImpl{}
|
|
|
|
step, err := sf.newStep(tt.model, &RunContext{})
|
|
|
|
assert.True(t, tt.check((step)))
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStepFactoryInvalidStep(t *testing.T) {
|
|
model := &model.Step{
|
|
Uses: "remote/action@v1",
|
|
Run: "cmd",
|
|
}
|
|
|
|
sf := &stepFactoryImpl{}
|
|
|
|
_, err := sf.newStep(model, &RunContext{})
|
|
|
|
assert.Error(t, err)
|
|
}
|