mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-08-07 09:24:22 +02:00
4c2ab943a8
gitea can not consume the runner's api by version while it's version mismatches the module version:
```
go: gitea.com/gitea/runner@v3.0.1: invalid version: module contains a go.mod file,
so module path must match major version ("gitea.com/gitea/runner/v3")
```
Fix that by bumping the module version now. The existing `v3.0.0` and `v3.0.1` tags stay unusable, so a new tag is needed after this lands.
Also drop the version `-X` linker flags, which would otherwise have to repeat the new path in both `Makefile` and `.goreleaser.yaml`, where a stale path makes injection silently no-op. Go has recorded the module version in the build info since 1.24, so `Version()` reads it from there, keeping the variable as an override for builds without a VCS stamp.
That part started as https://gitea.com/gitea/runner/pulls/1137 but belongs here: the stamp resolves against the tags that are legal for the module path, so without the `/v3` bump it would report `v1.0.9-0.<ts>-<sha>`. Since `release-nightly.yml` triggers on every push to `main`, splitting them would publish a nightly with a `v1` version.
---------
Co-authored-by: bircni <bircni@icloud.com>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1136
Reviewed-by: techknowlogick <9+techknowlogick@noreply.gitea.com>
Reviewed-by: bircni <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
54 lines
1.4 KiB
Go
54 lines
1.4 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package run
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.com/gitea/runner/v3/internal/pkg/config"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCanAcceptTaskDiskGuard(t *testing.T) {
|
|
cfg, err := config.LoadDefault("")
|
|
require.NoError(t, err)
|
|
cfg.Host.WorkdirParent = t.TempDir()
|
|
cfg.HealthCheck.Enabled = true
|
|
r := &Runner{cfg: cfg}
|
|
|
|
ready, _ := r.CanAcceptTask(t.Context())
|
|
assert.True(t, ready)
|
|
|
|
cfg.HealthCheck.MinFreeDiskSpaceMB = 1 << 40
|
|
ready, reason := r.CanAcceptTask(t.Context())
|
|
assert.False(t, ready)
|
|
assert.Contains(t, reason, "low disk space")
|
|
}
|
|
|
|
func TestDiskCheckDeferredWhileJobRuns(t *testing.T) {
|
|
cfg, err := config.LoadDefault("")
|
|
require.NoError(t, err)
|
|
cfg.HealthCheck.Enabled = true
|
|
cfg.HealthCheck.MinFreeDiskSpaceMB = 1
|
|
cfg.Host.WorkdirParent = t.TempDir()
|
|
r := &Runner{cfg: cfg}
|
|
|
|
ready, reason := r.CanAcceptTask(t.Context())
|
|
assert.True(t, ready)
|
|
assert.Equal(t, "ok", reason)
|
|
|
|
cfg.HealthCheck.MinFreeDiskSpaceMB = 1 << 40
|
|
r.runningCount.Store(1)
|
|
ready, reason = r.CanAcceptTask(t.Context())
|
|
assert.True(t, ready, "the disk check must not run while a job is active")
|
|
assert.Equal(t, "ok", reason)
|
|
|
|
r.runningCount.Store(0)
|
|
ready, reason = r.CanAcceptTask(t.Context())
|
|
assert.False(t, ready)
|
|
assert.Contains(t, reason, "low disk space")
|
|
}
|