act_runner/AGENTS.md at 8700adc933ecdb5bcb06ab3972c3d58362242672

mirror of https://gitea.com/gitea/act_runner.git synced 2026-08-06 08:54:21 +02:00

Files

bircni b70ff6893a feat: gate set-env/add-path and render annotation locations (#1109 )

`::set-env::` and `::add-path::` let a step rewrite the environment of every later step from its own output, which the runner honoured silently. They are now refused, as GitHub has done since 2020, and `ACTIONS_ALLOW_UNSECURE_COMMANDS` opts back in per step or job. Support for that variable is new here too, and is the only opt-in, matching GitHub rather than adding a runner config key on top.

Annotations keep their source location: Gitea has no annotation store and its web UI strips command properties, so `::error file=main.go,line=12::msg` is rendered as `::error::main.go:12: msg`.

`DEVELOPMENT.md` writes down the log line encoding rules this relies on.

---------

Co-authored-by: silverwind <me@silverwind.io>
Reviewed-on: https://gitea.com/gitea/runner/pulls/1109
Reviewed-by: silverwind <2021+silverwind@noreply.gitea.com>
Co-authored-by: bircni <bircni@icloud.com>

2026-08-05 16:43:17 +00:00

1.9 KiB

Raw Blame History

Never assume, verify before claiming
Use make help to find available development targets
PR descriptions: minimal, only what and why, no task lists or file listings
Reference issues and PRs by full URL, not by number
Use Conventional Commits for commit messages and PR titles, plus the enhance type for user-facing enhancements
Add an Assisted-by: AGENT_NAME:MODEL_VERSION trailer to commit messages, never Co-Authored-By or Signed-off-by
Attribute agent authorship on one trailing line in issue and pull request comments, never as a PR description section
Never force-push, amend, or squash unless asked. Use new commits and normal push for pull request updates
Comments: write almost none, short and preferably same-line, explaining why for a future reader. Never narrate code, the change or the prompt. Preserve existing ones that still apply
Add the current year into the copyright header of new .go files
Read DEVELOPMENT.md for internals and conventions
Ensure no trailing whitespace in edited files
Run make fmt after .go edits, make tidy after go.mod edits, and make checks for the non-lint source checks
Lint what changed with make lint-go, and make lint-go-windows for Windows and platform-split files
Fix the cause rather than disabling a linter or weakening a test. Where unavoidable, use the narrowest scope with a trailing comment giving the reason
Run single go tests with go test -run '^TestName$' ./modulepath/. make test self-skips the integration tests without docker or network, make test-dind runs the daemon-facing tests against the built dind image
Write the fewest, fastest tests covering the behavior, extending an existing one where possible. Prefer unit tests where logic is testable in isolation
Wait on a deterministic condition rather than sleep
Update the files under docs/ when behavior documented there changes

1.9 KiB Raw Blame History

1.9 KiB

Raw Blame History